AoE Songs not Affected by Instrument Modifiers

[nullyn]

Instrument Modifiers seem to be working for some songs, since when my bard has Thunderous Drum of Karana on she runs faster when Selo's is playing but they do not seem to modify AoE Dot songs at all.

AoE Dot songs being:

Chords of Dissonance (String Modifier)
​http://everquest.allakhazam.com/db/spell.html?spell=703

Denon's Disruptive Discord (Brass Modifier)
​http://everquest.allakhazam.com/db/spell.html?spell=730

Selo's Chords of Cessation (String Modifier)
​http://everquest.allakhazam.com/db/spell.html?spell=746

Song of Midnight (Brass Modifier)
​http://everquest.allakhazam.com/db/spell.html?spell=1756

Melody of Mischief (String Modifier)
​http://everquest.allakhazam.com/db/spell.html?spell=3365

[rottstein]

This has recently been fixed with a single line code change in the main code.

​http://www.eqemulator.org/forums/showthread.php?t=35179 is the thread with the fix.

Found in revision 2134, edit:
effect_value = CalcSpellEffectValue(spell_id, i, caster_level, caster);

[ptarp]

It appears this was already added at some time, and I'm not sure why the ticket wasn't closed other than maybe no testing?